Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: A positive inset was also shortening the whole key #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nharrer
Copy link

@nharrer nharrer commented Jan 29, 2024

Fix for #175

The bug was introduced in commit e88a398, which allowed the stem to stick out of the key (negative inset). However it broke positive insets (recessed stem).

@dsz-dsz-k
Copy link

Hi !
I'm glad I stumbled on your solution because I was at a loss trying to fix the inset function.
I've got another problem (see this issue: #203), would you happen to have some hint about it?

Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants